From 2c23992e527c06832bb34734165bab35f0efe9ed Mon Sep 17 00:00:00 2001
From: ewandor <ewandor@dorfsvald.net>
Date: Fri, 2 May 2025 11:59:10 +0200
Subject: [PATCH] Improve translation of dashboard and list

---
 gui/rpk-gui/public/locales/EN/common.json     | 13 +++++++++----
 gui/rpk-gui/public/locales/FR/common.json     | 13 +++++++++----
 gui/rpk-gui/src/pages/firm/base-page/List.tsx |  4 +++-
 gui/rpk-gui/src/pages/firm/index.tsx          | 15 ++++++---------
 4 files changed, 27 insertions(+), 18 deletions(-)

diff --git a/gui/rpk-gui/public/locales/EN/common.json b/gui/rpk-gui/public/locales/EN/common.json
index aea7065..34cb984 100644
--- a/gui/rpk-gui/public/locales/EN/common.json
+++ b/gui/rpk-gui/public/locales/EN/common.json
@@ -207,13 +207,15 @@
     "entity": {
       "entity_data": "Informations",
       "address": "Address",
-      "resource_title": "Entity"
+      "resource_title": "Entity",
+      "resource_plural": "Entities"
     },
     "provision_template": {
       "name": "Name",
       "title": "Title",
       "body": "Body",
-      "resource_title": "Provision Template"
+      "resource_title": "Provision Template",
+      "resource_plural": "Provision Templates"
     },
     "contract_template": {
       "name": "Name",
@@ -221,7 +223,8 @@
       "provisions": "Provisions",
       "parties": "Parties",
       "variables": "Variables",
-      "resource_title": "Contract Template"
+      "resource_title": "Contract Template",
+      "resource_plural": "Contract Templates"
     },
     "party_template": {
       "entity_id": "Party Template",
@@ -244,7 +247,8 @@
       "parties": "Parties",
       "provisions": "Provisions",
       "variables": "Variables",
-      "resource_title": "Contract Draft"
+      "resource_title": "Contract Draft",
+      "resource_plural": "Contract Drafts"
     },
     "draft_party": {
       "entity_id": "Client",
@@ -271,6 +275,7 @@
       "date": "Date",
       "location": "Location",
       "resource_title": "Contract",
+      "resource_plural": "Contracts",
       "draft_id": "Draft"
     }
   }
diff --git a/gui/rpk-gui/public/locales/FR/common.json b/gui/rpk-gui/public/locales/FR/common.json
index aa02ab2..2f4148a 100644
--- a/gui/rpk-gui/public/locales/FR/common.json
+++ b/gui/rpk-gui/public/locales/FR/common.json
@@ -207,13 +207,15 @@
     "entity": {
       "entity_data": "Informations",
       "address": "Adresse",
-      "resource_title": "Entité"
+      "resource_title": "Entité",
+      "resource_plural": "Entités"
     },
     "provision_template": {
       "name": "Nom",
       "body": "Corps",
       "title": "Titre",
-      "resource_title": "Template de Clause"
+      "resource_title": "Template de Clause",
+      "resource_plural": "Templates de Clauses"
     },
     "contract_template": {
       "name": "Nom",
@@ -221,7 +223,8 @@
       "parties": "Parties",
       "provisions": "Clauses",
       "variables": "Variables",
-      "resource_title": "Template de Contrat"
+      "resource_title": "Template de Contrat",
+      "resource_plural": "Templates de Contrats"
     },
     "party_template": {
       "entity_id": "Entité",
@@ -244,7 +247,8 @@
       "title": "Titre",
       "provisions": "Clauses",
       "variables": "Variables",
-      "resource_title": "Brouillon de Contrat"
+      "resource_title": "Brouillon de Contrat",
+      "resource_plural": "Brouillons de Contrats"
     },
     "draft_party": {
       "part": "Rôle",
@@ -270,6 +274,7 @@
     "contract": {
       "draft_id": "Brouillon",
       "resource_title": "Contrat",
+      "resource_plural": "Contrats",
       "location": "Lieu",
       "date": "Date"
     }
diff --git a/gui/rpk-gui/src/pages/firm/base-page/List.tsx b/gui/rpk-gui/src/pages/firm/base-page/List.tsx
index 47b2261..70a4937 100644
--- a/gui/rpk-gui/src/pages/firm/base-page/List.tsx
+++ b/gui/rpk-gui/src/pages/firm/base-page/List.tsx
@@ -5,6 +5,7 @@ import { Link, useNavigate } from "react-router"
 import React, { useContext } from "react";
 import { Button } from "@mui/material";
 import { FirmContext } from "../../../contexts/FirmContext";
+import { useTranslation } from "@refinedev/core";
 
 type ListProps<T extends GridValidRowModel> = {
   resource: string,
@@ -15,6 +16,7 @@ type ListProps<T extends GridValidRowModel> = {
 
 const List = <T extends GridValidRowModel>(props: ListProps<T>) => {
   const { resource, columns } = props;
+  const { translate: t } = useTranslation();
   const { currentFirm } = useContext(FirmContext);
   const resourceBasePath = `firm/${currentFirm.instance}/${currentFirm.firm}`
 
@@ -33,7 +35,7 @@ const List = <T extends GridValidRowModel>(props: ListProps<T>) => {
   return (
     <RefineList>
       <Link to={"create"} >
-        <Button>Create</Button>
+        <Button>{t("buttons.create")}</Button>
       </Link>
       <DataGrid
         {...dataGridProps}
diff --git a/gui/rpk-gui/src/pages/firm/index.tsx b/gui/rpk-gui/src/pages/firm/index.tsx
index d39ede6..f95c539 100644
--- a/gui/rpk-gui/src/pages/firm/index.tsx
+++ b/gui/rpk-gui/src/pages/firm/index.tsx
@@ -32,21 +32,18 @@ export const FirmRoutes = () => {
 }
 
 const FirmHome = () => {
-  const { currentFirm } = useContext(FirmContext);
   const { translate: t } = useTranslation();
-
   return (
     <>
-      <h1>This is la firme {currentFirm.instance} / {currentFirm.firm}</h1>
+      <h1>{t("dashboard.title")}</h1>
       <ul>
-        <li><Link to="entities">Entitées</Link></li>
-        <li><Link to="provisions">Templates de Clauses</Link></li>
-        <li><Link to="templates">Templates de Contrats</Link></li>
-        <li><Link to="drafts">Brouillons</Link></li>
-        <li><Link to="contracts">Contrats</Link></li>
+        <li><Link to="entities">{t("schemas.entity.resource_plural")}</Link></li>
+        <li><Link to="provisions">{t("schemas.provision_template.resource_plural")}</Link></li>
+        <li><Link to="templates">{t("schemas.contract_template.resource_plural")}</Link></li>
+        <li><Link to="drafts">{t("schemas.contract_draft.resource_plural")}</Link></li>
+        <li><Link to="contracts">{t("schemas.contract.resource_plural")}</Link></li>
       </ul>
     </>
-
   );
 }